Update dependencies and fix tests (hopefully) #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will hopefully fix errors seen on CI and locally: > Bundler could not find compatible versions for gem "bundler": > In Gemfile: > bundler (~> 2.0.1) > Current Bundler version: > bundler (2.1.4) > This Gemfile requires a different version of Bundler. > Perhaps you need to update Bundler by running `gem install bundler`?
This should fix these errors seen on CI and locally: > rubocop example lib spec Rakefile > /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml: Metrics/LineLength has the wrong namespace - should be Layout > Error: The `Layout/AlignArray` cop has been renamed to `Layout/ArrayAlignment`. > (obsolete configuration found in /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml, please update it) > The `Layout/Tab` cop has been renamed to `Layout/IndentationStyle`. > (obsolete configuration found in /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml, please update it) > The `Layout/TrailingBlankLines` cop has been renamed to `Layout/TrailingEmptyLines`. > (obsolete configuration found in /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml, please update it) > The `Lint/StringConversionInInterpolation` cop has been renamed to `Lint/RedundantStringCoercion`. > (obsolete configuration found in /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml, please update it) > obsolete parameter Whitelist (for Style/TrivialAccessors) found in /home/travis/.rvm/gems/ruby-2.6.3/gems/rubocop-govuk-1.0.0/config/gds-ruby-styleguide.yml > `Whitelist` has been renamed to `AllowedMethods`.
Error: The `Layout/IndentHeredoc` cop has been renamed to `Layout/HeredocIndentation`. (obsolete configuration found in .rubocop.yml, please update it)
lib/govuk_tech_docs/api_reference/api_reference_extension.rb:81:13: C: Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return) return text ^^^^^^ Rakefile:9:1: C: Rake/Desc: Describe the task with desc method. task :lint do ^^^^^^^^^^
tijmenb
approved these changes
Apr 17, 2020
|
@tijmenb thanks for the approval! Hope you're doing alright 👋 |
kevindew
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update all the things, which should hopefully fix CI that's currently failing
master.Suggest reviewing commit-by-commit.