Fixes and improvements to meta tags #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Realised that OpenGraph meta tags do in fact use the non-standard Will need to work out how to make the meta tags helper handle both cases. |
The `property` attribute is non-standard for `<meta>` elements, and is only intended to be used for opengraph meta tags (taken from RDFa). The correct attribute for other meta tags [1] (including Twitter's meta tags [2]) is `name`. Split the opengraph meta tags into a separate function which we can call from the view, allowing us to loop over the 'standard' and 'opengraph' meta tags separately, using `name` and `property` respectively. [1]: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta#Attributes [2]: https://developer.twitter.com/en/docs/twitter-for-websites/cards/guides/getting-started
Make it possible to add noindex robots meta tags to individual pages by adding `prevent_indexing: true` to the page frontmatter. Because the meta_tags helper now checks for the prevent_indexing property on the data object, we would now have to add the `prevent_indexing` attribute to every page_metadata double otherwise we would see the error: > #<Double "page_frontmatter"> received unexpected message :prevent_indexing with (no args) To avoid this, replace the current `data` test doubles with hashes, and update the meta_tags helper to use the standard Ruby syntax to read values out of the hashes, rather than relying on the method access [1] feature that we get from current_page.data being a Middleman::Util::EnhancedHash [2]. [1]: https://github.com/hashie/hashie/tree/b24d6dca2c545637bc3cc3ac4d89f565fc27a9d0#methodaccess [2]: https://github.com/middleman/middleman/blob/d7f0ed06d3bf10bd8bb7f9abfda87fcdfbb3c363/middleman-core/lib/middleman-core/util/data.rb#L18
|
I've updated the meta tags helper to return opengraph and non-opengraph tags separately, which I think solves the issue mentioned in the previous comment… |
36degrees
added a commit
to alphagov/tdt-documentation
that referenced
this pull request
Sep 4, 2020
Depends on alphagov/tech-docs-gem#192 being merged and released.
36degrees
added a commit
to alphagov/tdt-documentation
that referenced
this pull request
Sep 4, 2020
Depends on alphagov/tech-docs-gem#192 being merged and released. Co-authored-by: Mark Green <mark.green@digital.cabinet-office.gov.uk>
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using invalidEDIT: non opengraph tags using the non-standardpropertyattribute rather thannamepropertyattribute, which should only be used for opengraph / RDFa tags)prevent_indexing: truein the page frontmatter