Update GOV.UK Frontend and use new link styles #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfdebrux
changed the title
Updated package.json and ran `npm update`, following the steps in the README. Bumps [govuk-frontend](https://github.com/alphagov/govuk-frontend/): - [Release notes](https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md) - [Commits](alphagov/govuk-frontend@v3.6.0...v3.12.0)
GOV.UK Frontend v3.12.0 comes with new (optional) link styles that are designed to be easier to read and to have a clearer hover state [[1]]. This commit opts-in to the new link styles for the tech-docs-gem stylesheet, and refactors the table of contents navigation and search results links to use new the new link style mixins [[2]] so that they are styled consistently with other links. Note that this commit makes a small design change; search result links are now underlined when not hovered. [[1]]: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#links-are-easier-to-read-and-have-a-clearer-hover-state-opt-in [[2]]: https://frontend.design-system.service.gov.uk/sass-api-reference/#helpers-links
lfdebrux
force-pushed
the
ldeb-update-govuk-frontend
branch
from
60b2f64 to
1a8f4c5
Compare
lfdebrux
force-pushed
the
ldeb-update-govuk-frontend
branch
from
1a8f4c5 to
9c2f55a
Compare
govuk-frontend 3.7.0 changes the way that Sass dependencies work, so that CSS compiles faster [[1]]. This commit changes the Sass file for the tech docs gem to take advantage of the new system, by importing the component `index` stylesheets which don't include dependencies multiple times. This commit also changes the imports of govuk-frontend to import `govuk/base` instead of importing the settings, tools, and helpers by hand, as this will make it easier to migrate this repo to GOV.UK Frontend v4.0.0 when it is released. [1]: https://github.com/alphagov/govuk-frontend/blob/main/CHANGELOG.md#sass-now-compiles-faster
lfdebrux
force-pushed
the
ldeb-update-govuk-frontend
branch
from
9c2f55a to
bc6d1cd
Compare
Closed
4 tasks
kr8n3r
approved these changes
May 17, 2021
vanitabarrett
approved these changes
May 17, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOV.UK Frontend v3.12.0 comes with new (optional) link styles that are designed to be easier to read and to have a clearer hover state [1].
This PR updates the
govuk-frontendnpm package from 3.6.0 to 3.12.0 and opts-in to the new link styles for the tech-docs-gem stylesheet. We also refactor the table of contents navigation and search results links to use new the new link style mixins [2] so that they are styled consistently with other links.Note that this commit makes a small design change; search result links are now underlined when not hovered.
Part of alphagov/govuk-design-system#1641