Upgrade govuk-frontend and the crown logo #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with the new Tudor crown
Replace with the Tudor crown from govuk-frontend assets
manual Tudor Crown spacing adjustment from govuk-frontend 4.8
richardTowers
approved these changes
Feb 21, 2024
huwd
approved these changes
Feb 21, 2024
V4.8 contains SCSS source maps which the compiler here bundles in and then fails to import any other styles, resulting in a visually broken site Solution for now is to bring in v4.7 and the minor crown svg alignment
kr8n3r
force-pushed
the
upgrade-govuk-frontend
branch
from
0767f27 to
5bbf88d
Compare
abutters
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Tested locally on customs-declarations-end-to-end-service-guide. Works well. Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #337 #343
What’s changed
Ideally we would upgrade to govuk-frontend v4.8 and not have to bring in the minor manual SVG alignment, but as govuk-frontend v4.8 introduced SCSS source maps, the tech-docs gem compiler includes them but not any styles.
Identifying a user need
We need to update the crown before March 1
How to test with your tech docs
To see how your changes to the gem affect your website, point your website's Gemfile to your local checkout of this branch: