Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close search results on heading navigation. #37

Conversation

lewisnyman
Copy link
Contributor

…to close-search-results-on-heading-navigation

* 'master' of https://github.com/alphagov/tech-docs-gem:
  Replace default stop words filter with a custom function. The default list ignored useful words like 'get'
Copy link
Member

@paroxp paroxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I couldn't replicate the issue on Windows 10 x64 Google Chrome 68.0.3440.75. But the change looks harmless and for sure would prevent issue.

LGTM!

@jonathanglassman jonathanglassman merged commit 253d780 into alphagov:master Jul 31, 2018
@lewisnyman lewisnyman mentioned this pull request Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants