Update express dependency to fix vulnerability #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a medium security vulnerability because jasmine-browser-runner depends on express 4.20.0 which depends on serve-static 0.16.0 which depends on send 0.18.0, which is currently vulnerable due to GHSA-m6fv-jmcg-4jfg. The changes to yarn.lock were generated by running `yarn up -R express` to ensure it's using the patched version (0.19.0) of the send dependency.
brucebolt
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a medium security vulnerability because jasmine-browser-runner depends on express 4.20.0 which depends on serve-static 0.16.0 which depends on send 0.18.0, which is currently vulnerable due to GHSA-m6fv-jmcg-4jfg.
The changes to yarn.lock were generated by running
yarn up -R expressto ensure it's using the patched version (0.19.0) of the send dependency.This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.
Follow these steps if you are doing a Rails upgrade.