Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Bump engine and rds cert #372

Merged
merged 1 commit into from
Feb 3, 2020
Merged

Bump engine and rds cert #372

merged 1 commit into from
Feb 3, 2020

Conversation

samcrang
Copy link
Contributor

@samcrang samcrang commented Feb 3, 2020

Merge #371 first (and rebase).

@samcrang samcrang requested a review from a team as a code owner February 3, 2020 14:40
adityapahuja
adityapahuja previously approved these changes Feb 3, 2020
View reviewed changes
szd55gds
szd55gds previously approved these changes Feb 3, 2020
View reviewed changes
Copy link
Contributor

@szd55gds szd55gds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

@samcrang samcrang dismissed stale reviews from szd55gds and adityapahuja via 5d9767b February 3, 2020 16:12
@samcrang samcrang force-pushed the bump-engine-and-rds-cert branch from 8fbf0a8 to 5d9767b Compare February 3, 2020 16:12
@jakubmiarka
Copy link
Contributor

The previous #371 is failing build now:
Error: "ca_cert_identifier": this field cannot be set
https://deployer.tools.signin.service.gov.uk/teams/main/pipelines/verify-self-service/jobs/deploy-to-staging/builds/487#L5e29bfb9:55

Do we need to update the provider first?

adityapahuja
adityapahuja previously approved these changes Feb 3, 2020
View reviewed changes
@samcrang
Copy link
Contributor Author

samcrang commented Feb 3, 2020

@jakubmiarka Yup—I've fixed that now so this should be good to go.

@jakubmiarka
Copy link
Contributor

jakubmiarka commented Feb 3, 2020 •
edited
Loading

@jakubmiarka Yup—I've fixed that now so this should be good to go.

We need to go higher than the version you updated it too, because of this: hashicorp/terraform-provider-aws#10890

Until now, we've been using a fork: https://github.com/alphagov/verify-terraform-provider-aws

EDIT, ignore me, I thought it was pegged to 2.42...
Now it's failing on the postgres version?
Cannot upgrade postgres from 11.5 to 10.6 - https://deployer.tools.signin.service.gov.uk/teams/main/pipelines/verify-self-service/jobs/deploy-to-production/builds/175#L5e29c042:146

@samcrang
Bump the RDS Postgres engine version and RDS root CA
c167d31 
It doesn't appear that the `self-service` Rails app is verifying the
certificate RDS presents so we should be good to just start presenting
the new one.

We're also bumping the version of Postgres to match what is currently in
production. For some reason Postgres in production is version 11.5 where
as staging is 10.6.
@samcrang samcrang force-pushed the bump-engine-and-rds-cert branch from 5d9767b to c167d31 Compare February 3, 2020 17:30
@samcrang samcrang merged commit 6acb85b into master Feb 3, 2020
@samcrang samcrang deleted the bump-engine-and-rds-cert branch February 3, 2020 17:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jakubmiarka jakubmiarka jakubmiarka approved these changes

@adityapahuja adityapahuja adityapahuja approved these changes

@szd55gds szd55gds szd55gds left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samcrang @jakubmiarka @adityapahuja @szd55gds