-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreadable images aren't handled properly #147
Comments
Hello, Thanks for reporting this problem.
|
|
Thanks.
Do you have a version of Emacs 28 or 27 to test with? Emacs 29 is not yet released, so it would be helpful to know whether we're looking at a change in Emacs 29 or something else.
Is that the same as this? https://packages.guix.gnu.org/packages/emacs-ement/
Basically you would run it like this:
Then try to connect and use the client as you normally do. |
Yep.
Yep.
Thanks for the TLDR. Much appreciated! Give me a few days to do more testing and I'll get back here. |
By try to connect you mean to call |
BTW, This error still occurs on emacs 28 error in process sentinel: Wrong type argument: consp, nil GNU Emacs 28.2 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) I got the above 28.2 with Guix and ement is same version as before. |
This shouldn't happen, but somehow it is in #147.
No, I mean to use Ement ("the [Matrix] client") as you normally do. :) Please try running this commit: c55bc0b When encountering one of the rooms whose avatar is unexpectedly nil, it should display a warning with the room struct. With that information, we should be able to dig further and find out why the image is ending up nil. Depending on the room, the struct could be a large amount of data. Likely, we'll just need to get the room ID, and then add more debugging code to show what goes wrong with that room's avatar event. Thanks for your help. |
Also, for future reference, this should have been solved in #45, but... |
I ran this in a terminal: $ guix shell emacs-next emacs-ement --with-commit=emacs-ement=c55bc0b362eab1d4d2db495c1ed285ea264295a6 The above command install emacs 29 and I then, launched Emacs and executed The error completely went away and ement not runs as smooth as butter which I hadn't experienced yet :) I do have this new warning in
|
I'll make sure to update the Guix package once this fix is in |
Well, that commit isn't a fix, rather it adds debugging code that should allow us to locate the problem and then fix it in the right place. As you can see in the patch, it should display a warning like
Yes, that's because the error is ultimately signaled from the process sentinel, which Emacs handles by pausing for 2 seconds. I've recently learned that signaling errors from sentinels is bad, so a future version of |
Oh yeah, looking at the Do you need any info from it? |
Here's a snippet of the first couple of characters in the
|
The plan would be for you to give me the room ID (a string like |
I saw a room ID like that in |
Thanks. I pushed another commit to the branch |
Here ya go:
or screenshot on a different run: WDYT |
The above was tested in a > guix shell emacs-next emacs-ement --with-branch=emacs-ement=wip/147 --check
updating checkout of 'https://github.com/alphapapa/ement.el'...
retrieved commit a31cbeefca53bc065c8e637849caa2c90012a43f
guix shell: checking the environment variables visible from shell '/gnu/store/qvj03fib58k6ldcv3pas3523mz3baiic-zsh-5.8.1/bin/zsh'...
guix shell: All is good! The shell gets correct environment variables. |
Ok, I think I see the problem: When I open And apparently Emacs does not support ICO files at all, as So the "fix" in Ement will be basically what that branch does now, to show a warning when the avatar is downloaded and found unreadable, and to leave the room's avatar slot properly nil. In the meantime, you might want to advise the room's admin that they should replace the avatar with a real PNG image. Thanks for your help with this error. I'll release the fix in v0.9, since it's basically ready to tag anyway, I think. |
Hi,
I'm not sure what I should call this error but ement keeps complaining about the below.
I turned on
toggle-debug-on-error
and this is what I got.WDYT
Feel free to rename this issue to something more pertinent.
The text was updated successfully, but these errors were encountered: