Skip to content

Commit

Permalink
sof-soundwire: rt1308: Fix single amp configuration
Browse files Browse the repository at this point in the history
If the device have single rt1308 amp then the codec's Channel Select should
be set to "LR" and not to "LL". "LL" is only valid if we have 2 amps, in
that case one is the Left and the other is the Right channel.

This fixes for example Dell Latitude 9520 which only played on the Left
speaker, Right is silent.

Closes: #402
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
  • Loading branch information
ujfalusi authored and perexg committed Mar 11, 2024
1 parent 4e0fcc7 commit 9e29f9e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions ucm2/sof-soundwire/rt1308.conf
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,9 @@ DefineMacro.rt1308spk.If.0 {
SectionDevice."Speaker" {
Comment "Speaker"

Macro.num1.rt1308spk { ForAmps "[12]" Amp 1 Sel LL }
Macro.num2.rt1308spk { ForAmps "2" Amp 2 Sel RR }
Macro.num1.rt1308spk { ForAmps "1" Amp 1 Sel LR }
Macro.num2.rt1308spk { ForAmps "2" Amp 1 Sel LL }
Macro.num3.rt1308spk { ForAmps "2" Amp 2 Sel RR }

EnableSequence [
cset "name='Speaker Switch' on"
Expand Down

0 comments on commit 9e29f9e

Please sign in to comment.