X13s volume fixes #335
X13s volume fixes #335
Conversation
| @@ -5,6 +5,6 @@ EnableSequence [ | |||
| cset "name='WSA_RX1 INP0' RX1" | |||
| cset "name='WSA_COMP1 Switch' 1" | |||
| cset "name='WSA_COMP2 Switch' 1" | |||
| cset "name='WSA_RX0 Digital Volume' 68" | |||
| cset "name='WSA_RX1 Digital Volume' 68" | |||
| cset "name='WSA_RX0 Digital Volume' 84" | |||
There was a problem hiding this comment.
Won't be better to remove this settings from the EnableSequence and keep the initailization only in the BootSequence ?
There was a problem hiding this comment.
Makes sense, will update the PR with suggested changes.
There was a problem hiding this comment.
Sorry for the delay, branch is now pushed with suggested change.
Srinivas-Kandagatla
force-pushed
the
x13s-volume-fixes
branch
from
39420b0 to
42a4d4b
Compare
|
@Srinivas-Kandagatla, your updated pull-request is not functionally equivalent to your first one and causes the speaker volume to again be set too low. I tried adding back the volume csets to ucm2/codecs/qcom-lpass/wsa-macro/SpeakerEnableSeq.conf and that fixed the issue. Please investigate and respin ASAP so we can get this fixed as audio is currently broken on the X13s without these changes merged. |
|
@jhovold thanks for testing and reporting this, I think I found one issue here. We seems to be setting the same mixer WSA_RX0/WSA_RX1 Digital Volume in SpeakerDisableSeq.conf as well. So we will end up with low volume because of this. I have fixed this now, Will push to this PR with those changes. |
Current setup used Digital Volume to control Headset Volume which is pretty saturated after centain gain. Fix the Digital gain at 0dB and use Analog gain to do the volume control. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Add combined analog volume controls for Speakers in the init conf Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Make use of Speakers volume control to control analog gain on WSA Speakers. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Srinivas-Kandagatla
force-pushed
the
x13s-volume-fixes
branch
from
42a4d4b to
998018a
Compare
ucm2/codecs/wsa883x/init.conf
Outdated
| cset "name='WSA_RX0 Digital Volume' 84" | ||
| cset "name='WSA_RX1 Digital Volume' 84" | ||
| ] | ||
|
|
There was a problem hiding this comment.
You now also set these in BootSequence in wsa_macro/init.conf, do you really need both?
There was a problem hiding this comment.
No, it should be removed.
| cset "name='RX_RX0 Digital Volume' 80" | ||
| cset "name='RX_RX1 Digital Volume' 80" | ||
| cset "name='RX_RX0 Digital Volume' 84" | ||
| cset "name='RX_RX1 Digital Volume' 84" | ||
| cset "name='ADC2 Volume' 12" |
There was a problem hiding this comment.
This currently has no effect since you also set these to 80 in the EnableSequence. You need to drop the latter.
For some reason we ended up with a Digital gain below 0dB, resulting in a very low speaker volume. Fix this to 0dB and let Analog gain control speakers volume. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Srinivas-Kandagatla
force-pushed
the
x13s-volume-fixes
branch
from
998018a to
f6e8a4d
Compare
|
The updated fixes seem to work as intended. Note that with the addition of rx-macro/init.conf you now have a redundant initialisation of "RX_RX0 Digital Volume" in wcd938x/init.conf instead. Not sure if you want to respin this PR again or if you can just drop that as a follow-up clean up. |
For some reason we ended up with a Digital gain below 0dB, resulting in a very low HP volume. Fix this to 0dB and let Analog gain control HP volume. Also remove all redundant setting of this control. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Srinivas-Kandagatla
force-pushed
the
x13s-volume-fixes
branch
from
f6e8a4d to
e8c3e77
Compare
|
Still works after dropping the redundant initialisation so these should be good to go: Reviewed-by: Johan Hovold johan+linaro@kernel.org Note that users will need to clear their asound.state after updating the ucm configuration, and that after doing so headphone output is broken until a second reboot. So there still appears to be some bugs in these configuration files, but as I assume this issue was not introduced by this series that should be fixed separately. @perexg, is it possible to get this merged and included in the next release? |
Add combined analog volume controls for Speakers in the init conf Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Make use of Speakers volume control to control analog gain on WSA Speakers. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low speaker volume. Fix this to 0dB and let Analog gain control speakers volume. CloseS: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low HP volume. Fix this to 0dB and let Analog gain control HP volume. Also remove all redundant setting of this control. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Current setup used Digital Volume to control Headset Volume which is pretty saturated after centain gain. Fix the Digital gain at 0dB and use Analog gain to do the volume control. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Add combined analog volume controls for Speakers in the init conf Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Make use of Speakers volume control to control analog gain on WSA Speakers. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low speaker volume. Fix this to 0dB and let Analog gain control speakers volume. CloseS: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low HP volume. Fix this to 0dB and let Analog gain control HP volume. Also remove all redundant setting of this control. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Current setup used Digital Volume to control Headset Volume which is pretty saturated after centain gain. Fix the Digital gain at 0dB and use Analog gain to do the volume control. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Add combined analog volume controls for Speakers in the init conf Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
Make use of Speakers volume control to control analog gain on WSA Speakers. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low speaker volume. Fix this to 0dB and let Analog gain control speakers volume. CloseS: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
For some reason we ended up with a Digital gain below 0dB, resulting in a very low HP volume. Fix this to 0dB and let Analog gain control HP volume. Also remove all redundant setting of this control. Closes: #335 Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This patchset fixes some of the Volume issues that are seen on X13s, most of the existing ucm was controlling Digital Gains instead of Analog Gains. With this patchset the volume on both speakers are much better and not saturated.