amd-soundwire: add support for AMD generic soundwire legacy machine driver #470
Conversation
vijendarmukunda
changed the title
| @@ -0,0 +1,81 @@ | |||
| # Use case Configuration for amd-soundwire card | |||
|
|
|||
| If.RT722 { | |||
There was a problem hiding this comment.
The config is almost identical to ucm2/sof-soundwire . I would add/merge code. If AMD driver follow the similar components scheme (${CardComponents} string), it can be a good benefit to share configs.
There was a problem hiding this comment.
@perexg : Agreed. But due to time constraint, We need to release the UCM files to unblock the customer release. Let this PR go as initial version. We will look in to your suggested changes and implement the changes as next version.
There was a problem hiding this comment.
Could you show the components string ? amixer -c 0 info will print it (replace zero with the correct ALSA card number).
There was a problem hiding this comment.
Below is the component string output for amd-soundwire sound card.
Components : ' cfg-amp:1 hs:rt722 spk:rt722 mic:rt722'
There was a problem hiding this comment.
@perexg : We have identified one issue which may needs to update the UCM files. Please hold this pull request
Add support for AMD generic legacy(No DSP) machine driver for ACP6.3 platform. Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
vijendarmukunda
force-pushed
the
master
branch
from
b641b59 to
e25b37e
Compare
|
@perexg : posted v2 version. Please review the PR |
|
I really like to use one configuration for all soundwire bridges, because the connected chips and chip configurations are similar. I found only one difference between your config and the config in sof-soundwire directory - Note that review comments would be, but I prefer #478 way:
|
|
@perexg : Will fix the review comments and validate the PR#470 & PR#478 changes separately and let you know the test results |
Add support for AMD generic legacy(No DSP) machine driver for ACP6.3 platform using RT722 codec.