UCM2: Intel: sof-hda-dsp: Enable Dmic0 pre-processing and SDW speaker post-processing #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singalsu
commented
Dec 3, 2024
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
ac9367a to
f6c7a52
Compare
perexg
reviewed
Dec 5, 2024
| cset "name='Dmic0 Capture Switch' on" | ||
| ] | ||
| } | ||
| If.Dmic0Drc { |
There was a problem hiding this comment.
Could we move DRC/Beamformer Ifs to dsp.conf to have all related things in one place? Define a macro.
There was a problem hiding this comment.
Yep, it makes sense. I will start also with SoundWire codec PC's SOF processing setup, so I made for the macros the endpoint name a parameter.
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
f6c7a52 to
c84628b
Compare
singalsu
commented
Dec 5, 2024
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
c84628b to
7c8231b
Compare
singalsu
commented
Dec 10, 2024
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
7c8231b to
9fc75f8
Compare
singalsu
commented
Dec 10, 2024
singalsu
commented
Dec 10, 2024
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
9fc75f8 to
5010678
Compare
|
Converted to draft, this needs more testing. Also I will add a SDW speaker playback control patch. |
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
5010678 to
6094159
Compare
singalsu
changed the title
This patch moves SOF control blobs related variables set are to a new dsp.conf that is included from top level sof-hda-dsp.conf. The change allows to use the variables in InitBootSequence for the controls. E.g. customize the default blobs applied based on DMI ID of the device. There's no change to functionality in this patch. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch cleans up definitions in preparation to add more controlled processing for audio endpoints. - The algorithms names write style is aligned to e.g. "Iir" instead of "IIR" and "Iir" to avoid mistakes from typos. - Add prefix PostMixerAnalogPlayback to HDA analog playback blob names to separate them from other Speaker endpoints. - Similarly rename SofControl macro. The functionality is not changed. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This change adds a few blobs to use with SOF TDFB beamformer and updates the instructions how to generate the blobs in SOF. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
6094159 to
93e9553
Compare
|
Note: Added as 6th commit enable of SDW microphone array pre-processing in SOF after I got a device where I was able to test it. |
singalsu
commented
Dec 17, 2024
kv2019i
approved these changes
Dec 18, 2024
singalsu
commented
Dec 19, 2024
This patch enables the SOF microphone capture pre-processing features as BootSequence initial values if the controls for them are available. If the user later switches these off, they will remain off. The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signal-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user. The generic blobs in topology can be replaced with device specific blobs based on DMI ID. See ucm2/blobs/sof/product_configs and ucm2/blobs/sof/user_configs. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch enables SOF post-processing for soundwire speaker output. The DRC processing is enabled as BootSequence, and setup of DRC, IIR, and FIR equalizer blobs as FixedBootSeqeuence by DMI ID if custom blobs have been defined for the device in ucm2/blobs/sof/product_configs or ucm2/blobs/sof/user_configs. The DRC can be turned off permanently by user space if not desired since BootSequence is only used for first time UCM2 start. The DRC, IIR, FIR blobs are set as FixedBootSequence only if custom blobs are defined. Otherwise the blobs defined in topology remain in use. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
This patch enables as BootSequence the DRC and multi-microphone beamformer processing with the supplied blobs in topology. The enable is for defaults if there is no previous control state. The user can permanently switch off them if needed. If DMI ID based customization can done with scripts in blobs/sof/product_configs or blobs/sof/user_configs. If the blob file names are not empty the blobs are applied by UCM2 as FixedBootSequence in every boot to replace topology defaults. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
The SoundWire PCs with PCH-DMIC use the top level sof-soundwire.conf. This patch adds similar Dmic0 end-point processing enable as done in for DMIC in HDA codec PCs if the controls for processing exist. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
sof_intel_dmic_boot_enable_drc_tdfb
branch
from
93e9553 to
a624137
Compare
ujfalusi
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds enable of the microphone capture pre-processing features as BootSequence inital values if the controls for them are available. If the user later switches these off, they will remain off.
The DRC is dynamic range control that boosts the capture level, and the TDFB (time-domain fixed beamformer) improves capture signa-to-noise ratio for set beam angle direction. The used 0 degrees angle is defined as angle towards notebook computer user.