ucm2: sof-soundwire: Correct FixedBootSequence for dmic info #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the curly brackets with square brackets. The curly ones break the FixedBootSequence parsing by resetting the sequence. If the /var/lib/alsa/card0.conf.d is not present then UCM will fail because all sequences before the dmic is lost, including the card-init: # alsactl init alsa-lib main.c:619:(execute_cfgsave) unable to open file '/var/lib/alsa/card0.conf.d/42-sof-hdmi.conf': No such file or directory alsa-lib main.c:2456:(set_fixedboot_user) Unable to execute force boot sequence The full sequence supposed to be: card-init ctl-remap cs42l43 dmic hdmi Fixes: 9fa70ad ("sof-hda-dsp,sof-soundwire: add CaptureMicInfoFile fields for dmics") Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
|
@perexg, on fresh installs with alsa-ucm-conf 1.2.13 will fail to initialize UCM as the /var/lib/alsa/card0.conf.d is not present. On updated systems the FixedBootSequence will work, but somehow oddly: alsactl initalsa-lib parser.c:1237:(parse_sequence) error: sequence command 'echo dmic >> /tmp/ucm.debug' is ignored cat /tmp/ucm.debug The expected sequence should be: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the curly brackets with square brackets.
The curly ones break the FixedBootSequence parsing by resetting the sequence.
If the /var/lib/alsa/card0.conf.d is not present then UCM will fail because all sequences before the dmic is lost, including the card-init:
alsactl init
alsa-lib main.c:619:(execute_cfgsave) unable to open file '/var/lib/alsa/card0.conf.d/42-sof-hdmi.conf': No such file or directory alsa-lib main.c:2456:(set_fixedboot_user) Unable to execute force boot sequence
The full sequence supposed to be:
card-init
ctl-remap
cs42l43
dmic
hdmi
Fixes: 9fa70ad ("sof-hda-dsp,sof-soundwire: add CaptureMicInfoFile fields for dmics")