Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JEKYLL_ENV=development in Docker Compose setup #2336

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

saeub
Copy link
Contributor

@saeub saeub commented Apr 12, 2024

Fixes #2303.

See #2333 for discussion.

@george-gca
Copy link
Collaborator

This indeed overrides the setting JEKYLL_ENV=production from the Dockerfile when executing the compose right?

@saeub
Copy link
Contributor Author

saeub commented Apr 12, 2024

Yes, it does:

$ docker compose run jekyll bash -c 'echo $JEKYLL_ENV' 
development

@george-gca
Copy link
Collaborator

Just out of curiosity, how is the serve/build time with our docker image comparing now to the other one?

@saeub
Copy link
Contributor Author

saeub commented Apr 12, 2024

In my tests, with JEKYLL_ENV=development, it's the same as in the dev container image. I didn't do a thorough benchmark though.

@george-gca george-gca merged commit 0b6135e into alshedivat:master Apr 12, 2024
3 checks passed
BoAi01 pushed a commit to BoAi01/boai01.github.io that referenced this pull request May 7, 2024
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this pull request Jun 19, 2024
karapostK pushed a commit to karapostK/karapostK.github.io that referenced this pull request Jul 4, 2024
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Docker compose up' takes 4 minutes
3 participants