-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use JEKYLL_ENV=development in Docker Compose setup #2336
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This indeed overrides the setting |
Yes, it does: $ docker compose run jekyll bash -c 'echo $JEKYLL_ENV'
development |
Just out of curiosity, how is the serve/build time with our docker image comparing now to the other one? |
In my tests, with |
george-gca
approved these changes
Apr 12, 2024
BoAi01
pushed a commit
to BoAi01/boai01.github.io
that referenced
this pull request
May 7, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
siril-teja
pushed a commit
to siril-teja/siril-teja.github.io-old
that referenced
this pull request
Jun 19, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
karapostK
pushed a commit
to karapostK/karapostK.github.io
that referenced
this pull request
Jul 4, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
Suraj-Bhor
pushed a commit
to Suraj-Bhor/suraj-bhor.github.io
that referenced
this pull request
Aug 13, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
meiqing-wang
pushed a commit
to meiqing-wang/meiqing-wang.github.io
that referenced
this pull request
Oct 13, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
avishekanand
pushed a commit
to avishekanand/al-folio-homepage
that referenced
this pull request
Oct 22, 2024
Fixes alshedivat#2303. See alshedivat#2333 for discussion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2303.
See #2333 for discussion.