Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tweak] Update "search filters" displayed on the blog's front page #2480

Merged
merged 3 commits into from
Jun 7, 2024
Merged

[Tweak] Update "search filters" displayed on the blog's front page #2480

merged 3 commits into from
Jun 7, 2024

Conversation

rstein66
Copy link
Contributor

@rstein66 rstein66 commented Jun 5, 2024 •
edited
Loading

[Tweak] Update "search filters" on blog's front page

Current Behavior

1. Go to `blog/`
2. Select "🏷️ Blockquotes" "search filter"

=> `blog/category/blockquotes/` returns 404
current-01-blog-filters current-02-category-blockquotes

Resolution in PR

  1. Append 'blockquotes' to display_tags
  2. Replace 'blockquotes' with 'external-services' in display_categories

=> Display 'blockquotes' tag and 'external-services' category on blog's front page

v2-01
v2-02 v2-03

@rstein66 rstein66 marked this pull request as ready for review June 5, 2024 02:45
george-gca
george-gca requested changes Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@george-gca george-gca left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to keep blockquotes as tag, and just change the display_categories for external-services, since it is the only other category we have other than sample-posts.

@rstein66
Revert 6e1ac07
e1730ac
@rstein66
Update tags and categories on blog's front page
c9ee593 
- Display 'blockquotes' tag
- Display 'external-services' category
@rstein66 rstein66 requested a review from george-gca June 6, 2024 19:20
@george-gca george-gca merged commit 180ae31 into alshedivat:master Jun 7, 2024
2 of 3 checks passed
@rstein66 rstein66 deleted the tweak/add-blog-category branch June 8, 2024 01:55
siril-teja pushed a commit to siril-teja/siril-teja.github.io-old that referenced this pull request Jun 19, 2024
@rstein66 @siril-teja
[Tweak] Update "search filters" displayed on the blog's front page (a…
c6e6b29 
…lshedivat#2480)

# [Tweak] Update "search filters" on blog's front page

## Current Behavior

```
1. Go to `blog/`
2. Select "🏷️ Blockquotes" "search filter"

=> `blog/category/blockquotes/` returns 404
```

<img width="400" alt="current-01-blog-filters"
src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd">
<img width="400" alt="current-02-category-blockquotes"
src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876">

<hr>

## Resolution in PR

1. Append 'blockquotes' to
[`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295)
2. Replace 'blockquotes' with 'external-services' in
`display_categories`

=> Display 'blockquotes' tag and 'external-services' category on blog's
front page

<img width="400" alt="v2-01"
src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb">
<br>  
<img width="300" alt="v2-02"
src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9">
<img width="300" alt="v2-03"
src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
Suraj-Bhor pushed a commit to Suraj-Bhor/suraj-bhor.github.io that referenced this pull request Aug 13, 2024
@rstein66 @Suraj-Bhor
[Tweak] Update "search filters" displayed on the blog's front page (a…
fc548c6 
…lshedivat#2480)

```
1. Go to `blog/`
2. Select "🏷️ Blockquotes" "search filter"

=> `blog/category/blockquotes/` returns 404
```

<img width="400" alt="current-01-blog-filters"
src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd">
<img width="400" alt="current-02-category-blockquotes"
src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876">

<hr>

1. Append 'blockquotes' to
[`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295)
2. Replace 'blockquotes' with 'external-services' in
`display_categories`

=> Display 'blockquotes' tag and 'external-services' category on blog's
front page

<img width="400" alt="v2-01"
src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb">
<br>
<img width="300" alt="v2-02"
src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9">
<img width="300" alt="v2-03"
src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
meiqing-wang pushed a commit to meiqing-wang/meiqing-wang.github.io that referenced this pull request Oct 13, 2024
@rstein66
[Tweak] Update "search filters" displayed on the blog's front page (a…
3da6ce0 
…lshedivat#2480)

# [Tweak] Update "search filters" on blog's front page

## Current Behavior

```
1. Go to `blog/`
2. Select "🏷️ Blockquotes" "search filter"

=> `blog/category/blockquotes/` returns 404
```

<img width="400" alt="current-01-blog-filters"
src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd">
<img width="400" alt="current-02-category-blockquotes"
src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876">

<hr>

## Resolution in PR

1. Append 'blockquotes' to
[`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295)
2. Replace 'blockquotes' with 'external-services' in
`display_categories`

=> Display 'blockquotes' tag and 'external-services' category on blog's
front page

<img width="400" alt="v2-01"
src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb">
<br>  
<img width="300" alt="v2-02"
src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9">
<img width="300" alt="v2-03"
src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
avishekanand pushed a commit to avishekanand/al-folio-homepage that referenced this pull request Oct 22, 2024
@rstein66
[Tweak] Update "search filters" displayed on the blog's front page (a…
a310aa4 
…lshedivat#2480)

# [Tweak] Update "search filters" on blog's front page

## Current Behavior

```
1. Go to `blog/`
2. Select "🏷️ Blockquotes" "search filter"

=> `blog/category/blockquotes/` returns 404
```

<img width="400" alt="current-01-blog-filters"
src="https://github.com/alshedivat/al-folio/assets/5504473/dae7f061-864d-49f3-9af1-1ef30c8056cd">
<img width="400" alt="current-02-category-blockquotes"
src="https://github.com/alshedivat/al-folio/assets/5504473/c09422a9-a2c7-4f81-8534-1f310c4f9876">

<hr>

## Resolution in PR

1. Append 'blockquotes' to
[`display_tags`](https://github.com/alshedivat/al-folio/pull/2480/files#diff-ecec67b0e1d7e17a83587c6d27b6baaaa133f42482b07bd3685c77f34b62d883R295)
2. Replace 'blockquotes' with 'external-services' in
`display_categories`

=> Display 'blockquotes' tag and 'external-services' category on blog's
front page

<img width="400" alt="v2-01"
src="https://github.com/alshedivat/al-folio/assets/5504473/c2f62a12-578d-44e0-ae8c-d6998fe8e2cb">
<br>  
<img width="300" alt="v2-02"
src="https://github.com/alshedivat/al-folio/assets/5504473/8df86ea0-46d6-4389-904d-24965d74ace9">
<img width="300" alt="v2-03"
src="https://github.com/alshedivat/al-folio/assets/5504473/6407812a-2052-4e0c-88bf-0d70d1c03ed8">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-gca george-gca george-gca approved these changes

Assignees
No one assigned
Labels
bug-fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstein66 @george-gca @alshedivat