Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Altmetric badge not correctly set when Altmetric id is provided #2522

Merged
merged 11 commits into from
Jun 20, 2024
31 changes: 22 additions & 9 deletions _layouts/bib.liquid
Original file line number Diff line number Diff line change
Expand Up @@ -249,9 +249,20 @@
{% endif %}
</div>
{% if site.enable_publication_badges %}
{% assign entry_has_altmetric_badge = entry.altmetric or entry.doi or entry.eprint or entry.pmid or entry.isbn %}
{% assign entry_has_dimensions_badge = entry.dimensions or entry.doi or entry.pmid %}
{% assign entry_has_google_scholar_badge = entry.google_scholar_id %}
{% assign entry_has_altmetric_badge = false %}
{% if entry.altmetric != blank and entry.altmetric != 'false' %}
{% assign entry_has_altmetric_badge = true %}
{% endif %}

{% assign entry_has_dimensions_badge = false %}
{% if entry.dimensions != blank and entry.dimensions != 'false' %}
{% assign entry_has_dimensions_badge = true %}
{% endif %}

{% assign entry_has_google_scholar_badge = false %}
{% if entry.google_scholar_id != blank %}
{% assign entry_has_google_scholar_badge = true %}
{% endif %}
{% if entry_has_altmetric_badge or entry_has_dimensions_badge or entry_has_google_scholar_badge %}
<div class="badges">
{% if site.enable_publication_badges.altmetric and entry_has_altmetric_badge %}
Expand All @@ -261,12 +272,14 @@
data-hide-less-than="15"
data-badge-type="2"
data-badge-popover="right"
{% if entry.eprint %}
{% if entry.altmetric != blank and entry.altmetric != 'true' %}
george-gca marked this conversation as resolved.
Show resolved Hide resolved
data-altmetric-id="{{ entry.altmetric }}"
{% elsif entry.arxiv %}
george-gca marked this conversation as resolved.
Show resolved Hide resolved
data-arxiv-id="{{ entry.arxiv }}"
{% elsif entry.eprint %}
data-arxiv-id="{{ entry.eprint }}"
{% elsif entry.doi %}
data-doi="{{ entry.doi }}"
{% elsif entry.altmetric %}
data-altmetric-id="{{ entry.altmetric }}"
{% elsif entry.pmid %}
data-pmid="{{ entry.pmid }}"
{% elsif entry.isbn %}
Expand All @@ -277,12 +290,12 @@
{% if site.enable_publication_badges.dimensions and entry_has_dimensions_badge %}
<span
class="__dimensions_badge_embed__"
{% if entry.doi %}
{% if entry.dimensions != blank and entry.dimensions != 'true' %}
george-gca marked this conversation as resolved.
Show resolved Hide resolved
data-id="{{ entry.dimensions }}"
{% elsif entry.doi %}
data-doi="{{ entry.doi }}"
{% else %}
data-pmid="{{ entry.pmid }}"
{% else %}
data-id="{{ entry.dimensions }}"
{% endif %}
data-hide-zero-citations="true"
data-style="small_rectangle"
Expand Down