Unit tests & fixes #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cheesytim
commented
Jan 14, 2021
•
cheesytim
commented
- add tests for QButton
- add tests for QBreadcrumbs
- add tests for QCascader
- fix QDatepicker localization
- delete postfix prop from QBreadcrumbs
cheesytim
requested review from
Esvalirion,
ViZhe and
shamilfrontend
and removed request for
Esvalirion
ViZhe
requested changes
Jan 15, 2021
| &_exact-active:not(:first-child), | ||
| &_last:not(:first-child) { | ||
| font-weight: var(--font-weight-bold); | ||
| font-size: 16px; | ||
| line-height: var(--line-height-base); | ||
| color: var(--color-primary-black); | ||
| text-overflow: initial; |
| it('should emit click', () => { | ||
| const instance = shallowMount(Component); | ||
| instance.vm.handleClick(); | ||
| expect(instance.emitted()).toBeTruthy(); |
There was a problem hiding this comment.
тут кажется стоит указать конкретное событие которое ожидается эмитнутым
| expect(instance.vm.clearBtnVisible).toBeFalsy(); | ||
| }); | ||
| it('should return true if showClose is true', () => { | ||
| instance.vm.showClose = true; |
Esvalirion
approved these changes
Jan 15, 2021
ViZhe
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.