Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Transform primitives docstring updates #492

Merged
merged 16 commits into from
Apr 18, 2019
Merged

Transform primitives docstring updates #492

merged 16 commits into from
Apr 18, 2019

Conversation

thehomebrewnerd
Copy link
Contributor

Updated docstrings and added doctests for transform primitives.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Apr 12, 2019 •
edited
Loading

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   96.09%   96.09%           
=======================================
  Files         108      108           
  Lines        8862     8862           
=======================================
  Hits         8516     8516           
  Misses        346      346
Impacted Files Coverage Δ
...retools/primitives/standard/transform_primitive.py 100% <ø> (ø) ⬆️
...uretools/tests/utils_tests/test_list_primitives.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4145c...c704cea. Read the comment docs.

@gsheni gsheni requested review from gsheni and kmax12 April 12, 2019 19:19
kmax12
kmax12 suggested changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one comment about using "base feature" in the doc string. Otherwise, looking good and almost ready to merge.

featuretools/primitives/standard/transform_primitive.py Outdated Show resolved Hide resolved
kmax12
kmax12 approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@kmax12 kmax12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@gsheni gsheni merged commit 14939d1 into alteryx:master Apr 18, 2019
@rwedge rwedge mentioned this pull request Apr 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsheni gsheni gsheni approved these changes

@kmax12 kmax12 kmax12 approved these changes

Assignees

@thehomebrewnerd thehomebrewnerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thehomebrewnerd @CLAassistant @kmax12 @gsheni