fix(session): 🐛 Fix variant extrapolation #3146
clippy
5 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 5 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.72.0 (5680fa18f 2023-08-23)
- cargo 1.72.0 (103a7ff2e 2023-08-15)
- clippy 0.1.72 (5680fa18 2023-08-23)
Annotations
Check warning on line 761 in alvr/launcher/src/main.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> alvr/launcher/src/main.rs:761:24
|
761 | fs::create_dir_all(&installation_dir)?;
| ^^^^^^^^^^^^^^^^^ help: change this to: `installation_dir`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Check warning on line 759 in alvr/launcher/src/main.rs
github-actions / clippy
variable does not need to be mutable
warning: variable does not need to be mutable
--> alvr/launcher/src/main.rs:759:9
|
759 | let mut installation_dir = data_dir().extended(VERSIONS_SUBDIR).extended(&release.tag);
| ----^^^^^^^^^^^^^^^^
| |
| help: remove this `mut`
|
= note: `#[warn(unused_mut)]` on by default
Check warning on line 757 in alvr/launcher/src/main.rs
github-actions / clippy
unused variable: `buffer`
warning: unused variable: `buffer`
--> alvr/launcher/src/main.rs:757:9
|
757 | let buffer = download(tx, "Downloading Streamer", &url, client).await?;
| ^^^^^^ help: if this is intentional, prefix it with an underscore: `_buffer`
|
= note: `#[warn(unused_variables)]` on by default
Check warning on line 780 in alvr/launcher/src/main.rs
github-actions / clippy
unreachable expression
warning: unreachable expression
--> alvr/launcher/src/main.rs:780:5
|
763 | / match installation_type {
764 | | #[cfg(target_os = "linux")]
765 | | InstallationType::AppImage => {
766 | | installation_dir.push("ALVR-x86_64.AppImage");
... |
778 | | }
779 | | }
| |_____- any code following this `match` expression is unreachable, as all arms diverge
780 | Ok(())
| ^^^^^^ unreachable expression
|
= note: `#[warn(unreachable_code)]` on by default
Check warning on line 6 in alvr/launcher/src/main.rs
github-actions / clippy
unused import: `Permissions`
warning: unused import: `Permissions`
--> alvr/launcher/src/main.rs:6:22
|
6 | fs::{self, File, Permissions},
| ^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default