New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Middleware API fix #711

Merged

Que3216 merged 1 commit into main from qsh/middleware-api-fix

Oct 16, 2024

Contributor

Que3216 commented Oct 16, 2024 •

edited

Loading

Just realised allowing network requests to be dropped within transformNetworkResponse would make this behaviour hard to implement:

Returning null will cause the request and the corresponding response to be dropped from the payload.
At replay time if there is no exact match for a request that is transformed to null then the request
will be failed with 'net::ERR_FAILED'/'Failed to fetch' rather than automatically trying to find a
'closest match' in the recorded session.

This is an API break, but this API is not being used yet, so safe to change.


          Middleware API fix

6551b3c

Que3216 requested a review from edoardopirovano

October 16, 2024 11:23

edoardopirovano approved these changes

View reviewed changes

Que3216 merged commit 2c94a21 into main

3 checks passed

Que3216 deleted the qsh/middleware-api-fix branch

October 16, 2024 12:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet