Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Business Letter #21

Merged
merged 12 commits into from
Mar 12, 2024
Merged

feat: Business Letter #21

merged 12 commits into from
Mar 12, 2024

Conversation

scdanieli
Copy link
Contributor

@scdanieli scdanieli commented Feb 5, 2024 •
edited by barredterra
Loading

2024-02-15.Business.Letter.mov

To-do

  • Migrate to version 14
  • Update README
  • Roles and Permission (?)

@scdanieli scdanieli marked this pull request as ready for review February 15, 2024 16:21
PatrickDEissler
PatrickDEissler reviewed Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@PatrickDEissler PatrickDEissler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@scdanieli
l suggest to add following default permissions:

  • All (Perm Level: 0): All rights except cancelling/ deleting/ amending
  • All Perm Level: 0, Only if Creator!): Cancelling/ deleting/ amending
  • System Manager: All rights (please don't forget "Submit", "Cancel" and "Amend" rights. These are not set as default for System Manager.)

Apart from that, I think the PR can be merged.

@barredterra
Copy link
Member

barredterra commented Feb 20, 2024 •
edited
Loading

Let's use "Employee" instead of "All" (which would include Customers, Suppliers or other portal users)

@scdanieli
Copy link
Contributor Author

I just noticed that the translation is not functioning as intended. Comments will be saved in the language of the user who submits or cancels the Business Letter. I don't see a way to adjust this without modifying the framework.

@barredterra barredterra self-assigned this Mar 5, 2024
@barredterra
Copy link
Member

barredterra commented Mar 7, 2024 •
edited
Loading

We should probably also

  • add an "Address Display" field, in order to make it easier to use the address via print format builder
  • fetch the contact email into a field "Email ID", in order to get it pre-filled in the email dialog
  • enable "Print Hide" for all fields that are not supposed to get printed on the letter (and "Report Hide" where it makes sense)

@barredterra barredterra assigned scdanieli and unassigned barredterra Mar 7, 2024
@scdanieli
Copy link
Contributor Author

@barredterra all suggestions implemented ...

@scdanieli scdanieli requested a review from barredterra March 11, 2024 09:37
@barredterra barredterra assigned barredterra and unassigned scdanieli Mar 11, 2024
@barredterra barredterra merged commit ee8f2b0 into alyf-de:version-15 Mar 12, 2024
4 checks passed
@barredterra
Copy link
Member

@Mergifyio backport version-14

@barredterra barredterra removed their assignment Mar 12, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 12, 2024 •
edited
Loading

backport version-14

✅ Backports have been created

@mergify mergify bot mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickDEissler PatrickDEissler PatrickDEissler approved these changes

@barredterra barredterra barredterra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scdanieli @barredterra @PatrickDEissler