-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Business Letter): add company field #39
Merged
barredterra
merged 3 commits into
alyf-de:version-15
from
0xD0M1M0:feat_company_business_letter
Jul 24, 2024
Merged
feat(Business Letter): add company field #39
barredterra
merged 3 commits into
alyf-de:version-15
from
0xD0M1M0:feat_company_business_letter
Jul 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add company field to business letter to allow for standard letter heads to be used
barredterra
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly fine, just one small change.
erpnext_germany/erpnext_germany/doctype/business_letter/business_letter.json
Outdated
Show resolved
Hide resolved
"reqd" automatically sets "in_list_view" therefore also removed
barredterra
approved these changes
Jul 24, 2024
barredterra
changed the title
feat: add company field to business letter
feat(Business Letter): add company field
Jul 24, 2024
@Mergifyio backport version-14 |
✅ Backports have been created
|
barredterra
pushed a commit
that referenced
this pull request
Jul 24, 2024
# [15.4.0](v15.3.3...v15.4.0) (2024-07-24) ### Features * **Business Letter:** add company field ([#39](#39)) ([c6abea0](c6abea0))
mergify bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
(cherry picked from commit c6abea0)
barredterra
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add company field to business letter to allow for standard letter heads to be used