Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VAT ID Check): avoid re-checking Invalid Input (backport #51) #53

Merged
merged 1 commit into from
Oct 24, 2024
Merged

fix(VAT ID Check): avoid re-checking Invalid Input (backport #51) #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions erpnext_germany/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import frappe
from erpnext import get_default_company
from erpnext_germany.utils.eu_vat import parse_vat_id
from frappe.query_builder import DocType
from pypika import Interval
from pypika import functions as fn
Expand Down Expand Up @@ -78,7 +77,7 @@ def get_last_check_query(party_type: str):
)
.where(
(vat_id_checks.party_type == party_type)
& (vat_id_checks.status == "Completed")
& (vat_id_checks.status.isin(["Completed", "Invalid Input"]))
)
.groupby(vat_id_checks.party)
)
Expand Down