Fix UNIX socket support for MySQL in dump action #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you add "Closes #235" in the PR description so that it is linked to the bug and will automatically close it when merged? |
amacneil
reviewed
Jan 27, 2022
pkg/driver/mysql/mysql.go
Outdated
| @@ -145,6 +145,9 @@ func (drv *Driver) mysqldumpArgs() []string { | |||
| if password, set := drv.databaseURL.User.Password(); set { | |||
| args = append(args, "--password="+password) | |||
| } | |||
| if socket := drv.databaseURL.Query().Get("socket"); drv.databaseURL.Hostname() == "" && socket != "" { | |||
There was a problem hiding this comment.
I forget, do we have any tests for this function? Would be nice to add a test to cover the new functionality.
There was a problem hiding this comment.
Currently, no. But I might try to come up with some testing. Let me see what I can do :-)
|
Thanks! I added some tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mysqldumpArgswas missing the--socketparameter when launchingmysqldumpfor UNIX socket connections. This pull request adds the parameter if thesocketquery option is added in the database URLCloses #235