Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes typo in error message: up bock -> up block #341

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Fixes typo in error message: up bock -> up block #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/dbmate/migration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ var (

// Error codes
var (
ErrParseMissingUp = errors.New("dbmate requires each migration to define an up bock with '-- migrate:up'")
ErrParseMissingUp = errors.New("dbmate requires each migration to define an up block with '-- migrate:up'")
ErrParseUnexpectedStmt = errors.New("dbmate does not support statements defined outside of the '-- migrate:up' or '-- migrate:down' blocks")
)

Expand Down
4 changes: 2 additions & 2 deletions pkg/dbmate/migration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ drop table users;

_, _, err = parseMigrationContents(migration)
require.NotNil(t, err)
require.Equal(t, "dbmate requires each migration to define an up bock with '-- migrate:up'", err.Error())
require.Equal(t, "dbmate requires each migration to define an up block with '-- migrate:up'", err.Error())

// It allows leading comments and whitespace preceding the migrate blocks
migration = `
Expand Down Expand Up @@ -128,5 +128,5 @@ ADD COLUMN status status_type DEFAULT 'active';

_, _, err = parseMigrationContents(migration)
require.NotNil(t, err)
require.Equal(t, "dbmate requires each migration to define an up bock with '-- migrate:up'", err.Error())
require.Equal(t, "dbmate requires each migration to define an up block with '-- migrate:up'", err.Error())
}