Don't use connection string in sqlite commands that expect a db file path #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dump command wasn't working with my sqlite database url, which had connections params in the query string.
Some digging showed the connection string being passed in two places where a file path is expected.
This changes those two places to use the file path instead. I'm not 100% sure the way I compute will work in every case (just taking url.Opaque). It needs some tests and additional handling to make it more robust to other people's use cases, this was just sufficient to solve my problem.
If I know what other form of database urls are expected to be handled, I can add that.