Cop for checking empty raise #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addded rspec test case for the cop. |
SowmyaAmagi
reviewed
Aug 2, 2022
SowmyaAmagi
reviewed
Aug 3, 2022
SowmyaAmagi
approved these changes
Aug 3, 2022
rparjun
reviewed
Aug 3, 2022
rparjun
reviewed
Aug 3, 2022
lib/cops/raise_message_cop.rb
Outdated
| return unless node.command?(:raise) | ||
| # If the raise encountered does not have any arguments, add the offense | ||
| # It ensures that raise is always accompanied with an argument. | ||
| if node.arguments.size<1 |
There was a problem hiding this comment.
i guess raise without argument is valid inside an exception handler block. In that case, it will raise the exception which it just caught, can you verify it?
There was a problem hiding this comment.
For exception handler cases, raise will return a "RunTime" error if given without argument by default, if we want to raise an Exception, we need to pass it as an argument.
With no arguments, raises the exception in "$!" or raises a RuntimeError if "$!" is nil.
There was a problem hiding this comment.
I was talking about this case: https://stackoverflow.com/a/23771227
gvaibhav1734
reviewed
Aug 3, 2022
gvaibhav1734
reviewed
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a cop to check that every "raise" has some arguments.