Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grant Access button doesn't work for files opened by intent #43

Closed
amake opened this issue May 6, 2021 · 3 comments
Closed

Grant Access button doesn't work for files opened by intent #43

amake opened this issue May 6, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@amake
Copy link
Owner

amake commented May 6, 2021

There are some issues providing access and following the file links on Android 10.

Could you be more specific?

Sure. The Grant Access buttons (on top and when tapping the actual link) don't seem to do anything.
Tapping the link to an image reports that there is no app which handles the file type.

Originally posted by @mistery in #35 (comment)

@amake amake added the bug Something isn't working label May 6, 2021
amake added a commit that referenced this issue May 6, 2021
For instance with non-persistable grants such as when opening by intent

See #43
@amake
Copy link
Owner Author

amake commented May 6, 2021

I was able to reproduce on Android in the case of opening a file via intent (as opposed to opening a file via the file picker).

It's not possible to resolve links relative to a file opened by intent on Android, because the URI obtained by doing so is not usable with the required APIs.

It may be possible to resolve links in the equivalent iOS scenario, depending on the storage provider (local storage and iCloud may work; third-party apps generally do not work).

I will address this as follows:

  1. The Grant Access banner won't be shown if the file is known not to support resolving relative links
  2. Better feedback in other scenarios

@alensiljak
Copy link

Oh, I forgot about that detail since the files have been sitting in the list for a long time.

@amake
Copy link
Owner Author

amake commented May 12, 2021

The changes I described are in v1.18.3 which is out for all platforms. If still nothing happens when tapping Grant Access or there is an error message that seems wrong feel free to reopen.

@amake amake closed this as completed May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants