fix: Replace fbprophet for prophet in requirements.txt #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amancevice
requested changes
Oct 29, 2021
tomasfarias
force-pushed
the
update-prophet
branch
from
b83ba15
to
f76eb3f
Compare
amancevice
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like the
fbprophetpackage (https://pypi.org/project/fbprophet/) was renamed to justprophetonce upgraded to version 1.0 (https://pypi.org/project/prophet/).Superset started requiring
prophetinstead offbprophet(see PR: apache/superset#14228) which is causing an error to pop up when installing this repo's image and attempting to use any of theprophetfunctionality:Solution: replace
fbprophetforprophetto match Superset'ssetup.py: https://github.com/apache/superset/blob/1.3/setup.py#L148