Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prophet to requirements #265

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

Gloccck
Copy link
Contributor

@Gloccck Gloccck commented Nov 15, 2023

Adds possibility of using predictive analytics by resolving missing dependency.
Image20231115184001

Note: prophet version higher than 1.1.1 is not compatible with current holidays version.

@@ -54,6 +54,7 @@ oauthlib==2.1.0
openpyxl==3.1.2; python_version >= '3.6'
packaging==23.2; python_version >= '3.7'
pillow==10.0.1; python_version >= '3.8'
prophet==1.1.1; python_version >= '3.7'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be added to the Pipfile and locked — which I could not get to happen so best of luck to you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

zipp==3.17.0; python_version >= '3.8'
zope.event==5.0; python_version >= '3.7'
zope.interface==6.1; python_version >= '3.7'
zstd==1.5.5.1
alembic==1.12.1; python_version >= '3.7'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requirements-dev.txt seemed to contain both default and dev dependencies, I've regenerated it with a --dev-only option, so now it contains only the dev dependencies.

@@ -6,6 +6,7 @@ name = "pypi"
[packages]
apache-superset = "==3.0.1"
cython = "==3.0.3"
holidays = "==0.23"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version has to be set explicitly (newer version is not compatible with prophet).

@amancevice
Copy link
Owner

Does pipenv lock succeed for you with these changes? It does not for me so I'm hesitant to merge

@Gloccck
Copy link
Contributor Author

Gloccck commented Nov 21, 2023

Does pipenv lock succeed for you with these changes? It does not for me so I'm hesitant to merge

It does.

image

However, to update lock file, I used pipenv upgrade --dev prophet==1.1.1 to avoid upgrading other not relevant dependencies.

@amancevice amancevice merged commit bb4a5a0 into amancevice:main Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants