Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: updates regarding dependabot issues. node 18 workflow & engine update #229

Merged
merged 14 commits into from
Mar 16, 2023

Conversation

EelcoLos
Copy link
Contributor

@EelcoLos EelcoLos commented Mar 10, 2023

EelcoLos and others added 3 commits March 10, 2023 16:12
this safely updates the packages which would be peer dependant.
Because of `semantic-release update` to `20.1.1`, node 18 is required

ncu: https://www.npmjs.com/package/npm-check-updates
due to `semantic-release` requiring node 18
all node workflows need updating too
Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8.
- [Release notes](https://github.com/minimistjs/minimist/releases)
- [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md)
- [Commits](minimistjs/minimist@v1.2.5...v1.2.8)

---
updated-dependencies:
- dependency-name: minimist
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@EelcoLos EelcoLos changed the title feat: updates regarding dependabot issues. node 18 workflow & engine update feat!: updates regarding dependabot issues. node 18 workflow & engine update Mar 10, 2023
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for looking into this! 👏

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@EelcoLos
Copy link
Contributor Author

EelcoLos commented Mar 15, 2023

question:
the lint-pr-title-preview-outputErrorMessage file doesn't have a yml extension. Is that intended? If not, should I add the extension, therefore enabling the action (in this PR or seperate)?

@amannn
Copy link
Owner

amannn commented Mar 15, 2023

the lint-pr-title-preview-outputErrorMessage file doesn't have a yml extension. Is that intended? If not, should I add the extension, therefore enabling the action (in this PR or seperate)?

Right, that's definitely an oversight! If you don't mind, would be great if you could enable it! You can do it directly in this PR if that's easier.

@EelcoLos EelcoLos force-pushed the package-updates-and-node-18 branch from 164d457 to 97cc4e9 Compare March 15, 2023 08:39
as there is no official using 'node18' yet
i've seen some composite solutions.
Pointed this out in the PR
the build for semantic-release needs v18, the rest does not
@EelcoLos EelcoLos changed the title feat!: updates regarding dependabot issues. node 18 workflow & engine update feat: updates regarding dependabot issues. node 18 workflow & engine update Mar 16, 2023
Copy link
Owner

@amannn amannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you again for your help and the patience! Hopefully we can upgrade to Node.js 18 in the future when it's properly supported in GitHub Actions!

@amannn amannn merged commit e797448 into amannn:main Mar 16, 2023
@github-actions
Copy link

🎉 This PR is included in version 5.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@EelcoLos EelcoLos deleted the package-updates-and-node-18 branch October 31, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various vulnerabilities
2 participants