feat: Deprecate defaultTranslationValues
#1411
Merged
+89
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
18 tasks
…ulttranslationvalues # Conflicts: # examples/example-app-router-playground/src/app/[locale]/page.tsx
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
defaultTranslationValuesallow to share global values to be used in messages across your app. The most common case are shared rich text elements (e.g.b: (chunks) => <b>{chunks}</b>).However, over time this feature has shown drawbacks:
Due to this, the feature will be deprecated and the docs will suggest a better alternative for common tags in rich text that doesn't have the limitations mentioned above (updated docs). Shared values don't get a direct replacement from
next-intl, but should be handled as part of your app logic (e.g. a shared module, React Context, etc.).Note: #410 can not be implemented immediately as part of this, as long as
defaultTranslationValuesare still available (even if deprecated). Instead, this feature could be added as part of the next major release.Contributes to #611