-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Remove default of now={new Date()}
from NextIntlClientProvider
for usage with format.relativeTime
(preparation for dynamicIO
)
#1536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…ntProvider`, adjust docs
amannn
changed the title
feat: Groundwork for
feat!: Only pass Nov 13, 2024
dynamicIO
now
to client side via NextIntlClientProvider
if it's provided in i18n/request.ts
amannn
changed the title
feat!: Only pass
feat!: Prepare for Nov 13, 2024
now
to client side via NextIntlClientProvider
if it's provided in i18n/request.ts
dynamicIO
and ppr
amannn
changed the title
feat!: Prepare for
feat!: Only pass Nov 13, 2024
dynamicIO
and ppr
now
to client side via NextIntlClientProvider
in case it's defined in i18n/request.ts
(preparation for dynamicIO
)
amannn
changed the title
feat!: Only pass
feat!: Remove default of Nov 14, 2024
now
to client side via NextIntlClientProvider
in case it's defined in i18n/request.ts
(preparation for dynamicIO
)now={new Date()}
from NextIntlClientProvider
for usage in format.relativeTime(…)
amannn
changed the title
feat!: Remove default of
feat!: Remove default of Nov 14, 2024
now={new Date()}
from NextIntlClientProvider
for usage in format.relativeTime(…)
now={new Date()}
from NextIntlClientProvider
for usage with format.relativeTime
amannn
changed the title
feat!: Remove default of
feat!: Remove default of Nov 14, 2024
now={new Date()}
from NextIntlClientProvider
for usage with format.relativeTime
now={new Date()}
from NextIntlClientProvider
for usage with format.relativeTime
(preparation for dynamicIO
)
This was referenced Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr; — Are you using
format.relativeTime
in Client Components? If not, you can skip this.If you've used
format.relativeTime
in Client Components previously, you might have relied on a default ofnow={new Date()}
being set onNextIntlClientProvider
:In preparation for
dynamicIO
andppr
, the default fornow
onNextIntlClientProvider
has now been removed. Note however that if you're configuring anow
value ini18n/request.ts
, this is still inherited byNextIntlClientProvider
.Therefore, if you just want to restore the previous behavior, you can do so in
i18n/request.ts
:However, if you want to prepare for upcoming rendering features in Next.js already, the relative time formatting docs now suggest to always provide
now
explicitly based onuseNow()
:If you don't provide
now
globally, this has a few benefits:now
globally if relevant, e.g. for consistent results when running testsLearn more in the docs for
useNow
.Resolves #1464