feat: Invoke notFound()
when no locale was attached to the request and update docs to suggest validating the locale in i18n.ts
#742
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are currently struggling with errors that are caused by these two scenarios:
next-intl
APIs (e.g. #736)tldr:
locale
ini18n.ts
. If you've previously validated the locale e.g. in the root layout, you can move this validation toi18n.ts
now. This change is recommended to all users.next-intl
will now call thenotFound()
function when the middleware didn't run on a localized request andnext-intl
APIs are used during rendering. Previously this would throw an error, therefore this is only relevant for you in case you've encountered the corresponding error. If you've previously been affected by this error, please make sure that your middleware matcher is set up correctly and that you're providing anot-found
page that can be rendered in this case.Handling invalid locales
Users run into this error because the locale wasn't sufficiently validated. This is in practice quite hard because we currently educate in the docs that this should happen in the root layout, but due to the parallel rendering capabilities of Next.js, potentially a page or
generateMetadata
runs first.Therefore moving this validation to a more central place seems necessary. Due to this, the docs will now suggest validating the locale in
i18n.ts
. By doing this, we can catch erroneous locale arguments in a single place before e.g. importing JSON files.The only edge case is if an app uses no APIs of
next-intl
in Server Components at all and thereforei18n.ts
doesn't run. This should be a very rare case though as evenNextIntlClientProvider
will calli18n.ts
. The only case to run into this is if you're usingNextIntlClientProvider
in a Client Component and delegate all i18n handling to Client Components too. If you have such an app,i18n.ts
will not be invoked and you should validate thelocale
before passing it toNextIntlClientProvider
.Handling missing locales
This warning is probably one of the most annoying errors that users currently run into:
The various causes of this error are outlined in the docs.
Some of these cases should simply be 404s (e.g. when your middleware matcher doesn't match
/unknown.txt
), while others require a fix in the matcher (e.g. considering/users/jane.doe
when usinglocalePrefix: 'as-necessary'
).My assumption is that many of these errors are false positives that are caused by the
[locale]
segment acting as a catch-all. As a result, a 500 error is encountered instead of 404s. Due to this, this PR will downgrade the previous error to a dev-only warning and will invoke thenotFound()
function. This should help in the majority of cases. Note that you should define anot-found
file to handle this case.I think this change is a good idea because if you're using
unstable_setRequestLocale
and you have a misconfigured middleware matcher, you can provide any kind of string tonext-intl
(alsounknown.txt
) and not run into this error. Therefore it only affects users with dynamic rendering. Validating the locale ini18n.ts
is the solution to either case (see above). Also in case something likerouteParams
gets added to Next.js, the current warning will be gone entirely—therefore tackling it from a different direction is likely a good idea.The false negatives of this should hopefully be rather small as we consistently point out that you need to adapt your middleware matcher when switching the
localePrefix
to anything other thanalways
. Dev-only warnings should help to get further information for these requests.Closes #736
Closes #716
Closes #446