Merge pull request #15 from bomoko/hotfix/fix_pagination

Adds function to get all bulk certificates via pagination
amazeeio · Dec 15, 2020 · 3959421 · 3959421
2 parents 4b8fbbf + 950cb44
commit 3959421
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 3 deletions.
diff --git a/src/Fastly/Types/FastlyCertificates.php b/src/Fastly/Types/FastlyCertificates.php
@@ -7,6 +7,10 @@
 
 class FastlyCertificates extends FastlyRequest
 {
+
+    const MAX_CERTIFICATES_FROM_ENDPOINT = 200;
+    const MAX_CERTIFICATE_PAGES_TO_PULL = 50; //this will allow up to 10000 certificates
+
     public $data;
     public $links;
     public $meta;
@@ -142,6 +146,42 @@ public function getTLSBulkCertificates($options = '')
         return $certificates;
     }
 
+    public function getAllBulkCertificates()
+    {
+        $lastPage = false;
+        $options = sprintf("page[size]=%d",
+          self::MAX_CERTIFICATES_FROM_ENDPOINT);
+        $pageCount = 0;
+
+        $totalCertificateData = [];
+
+        while (!$lastPage && $pageCount++ < self::MAX_CERTIFICATES_FROM_ENDPOINT) {
+            $certificateData = self::getTLSBulkCertificates($options);
+            $totalCertificateData[] = $certificateData['data'];
+
+            $currentPage = $certificateData['meta'][0]['current_page'];
+            $totalPages = $certificateData['meta'][0]['total_pages'];
+
+            if(!is_numeric($currentPage) || !is_numeric($totalPages)) {
+                throw new \Exception("Call to getAllBulkCertificates resulted in bad results from Fastly API");
+            }
+
+            if ($currentPage >= $totalPages) {
+                $lastPage = true;
+            } else {
+                $options = sprintf("page[size]=%d&page[number]=%d",
+                  self::MAX_CERTIFICATES_FROM_ENDPOINT, ++$currentPage);
+            }
+        }
+
+        return [
+          'data' => array_reduce($totalCertificateData, function ($c, $e) { return array_merge($c, $e);}, []),
+          'links' => [],
+          'meta' => [],
+        ];
+
+    }
+
     /**
      * Upload a new certificate.
      *

diff --git a/tests/Fastly/FastlyTLSBulkCertificateTest.php b/tests/Fastly/FastlyTLSBulkCertificateTest.php
@@ -31,22 +31,28 @@ public function testGetFastlyCertificates()
     {
       $certificatesObject = $this->fastly->certificates;
       $certificates = $certificatesObject->get_tls_certificates();
-
       // Get whole response from API.
       $this->assertArrayHasKey('data', $certificates);
     }
 
     public function testGetPlatformTLSCertificates()
     {
         $certificatesObject = $this->fastly->certificates;
-        $certificates = $certificatesObject->getTLSBulkCertificates();
-
+        $certificates = $certificatesObject->getTLSBulkCertificates('page[size]=200');
         // Get whole response from API.
         $this->assertArrayHasKey('data', $certificates);
         $this->assertArrayHasKey('links', $certificates);
         $this->assertArrayHasKey('meta', $certificates);
     }
 
+    public function testGetAllBulkCertificates()
+    {
+        $certificates = $this->fastly->certificates->getAllBulkCertificates();
+        $this->assertArrayHasKey('data', $certificates);
+        $this->assertArrayHasKey('links', $certificates);
+        $this->assertArrayHasKey('meta', $certificates);
+    }
+
     //public function testGetCertificateByID()
     //{
     //    $certificatesObject = $this->fastly->certificates;