-
Notifications
You must be signed in to change notification settings - Fork 73
Java 7 and Tomcat 8 support + AWS SDK updated #17
Conversation
I'd really like to see Tomcat 8 support integrated. However, this pull request includes a lot of unnecessary whitespace changes to these files: Revert the whitespace changes and resubmit and maybe it will actually have a chance of getting merged. |
This reverts commit 646e6d9.
Done. I formatted the POM in the last commit on purpose to keep it in a better shape. |
Hold this pull. I found some strange behavior that I would like to pin down before merging. |
Ok, this pull is good to go, the strange behavoir was a quirk of our code on Java 8 (boxing/unboxing issues). It should be noted that it wasn't tested on Tomcat 7. |
We have accepted pull request #16 which updates the SDK dependency. For the Tomcat 8 changes, I believe they are not backwards-compatible with Tomcat 7, since getContext() was not added until Tomcat 8. We can't accept this change and then break all the Tomcat 7 users. |
You are right, Tomcat 8 changes are not backwards-compatible. I'm sorry to have introduced a non compatible modification. We should create another branch for Tomcat 8 support. |
Wouldn't you create a Tomcat 7 legacy branch, that over time can be deprecated when Tomcat 7 reaches end of life? |
Good suggestion Henri. We should spin up a tomcat-7 branch for the current code and move on to Tomcat 8 for the master branch. |
👍 It is a really good idea. |
We are accepting this pull request with a few modifications to preserve backwards compatibility with Tomcat 7. Thanks for the contribution! |
Thanks! Today I planned to do more Tomcat DynamoDB sessions' testing and your message arrived at the perfect time. |
During you test try to modify some data in the stored session. After 30 seconds the changes will be lost.... |
Selindek, how consistenly are you seeing this behavior? |
Tried it with the current and the previous release and seeing the issue sporadically in both. This seems to be the same issue pointed out in your pull request #19, correct? |
Yes that's the same issue. But it happened continuously in our system. That's why I created my version. We use my version on a live server for more than a month and there are no any problems. |
In order to keep this project working on the latest versions of Java and Tomcat's available packages, I created this pull request.