Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: Use new parametrization scheme for gates #63

Merged
merged 4 commits into from
Jul 31, 2023

Conversation

kshyatt-aws
Copy link
Member

Issue #, if available: N/A

Description of changes: Change the supertype of angled gates to be a parametrized abstract type containing the total angle count. This allows us to simply the gate application code.

Testing done: Unit and integ tests passed locally.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

Tests

  • I have installed and run git secrets to make sure I did not commit any sensitive information (passwords or credentials)
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have checked that my tests are not configured for a specific region or account (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023

Codecov Report

Patch coverage: 83.12% and project coverage change: -0.37% ⚠️

Comparison is base (e5d46af) 95.66% compared to head (136a48c) 95.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
- Coverage   95.66%   95.30%   -0.37%     
==========================================
  Files          35       35              
  Lines        4040     3831     -209     
==========================================
- Hits         3865     3651     -214     
- Misses        175      180       +5     
Files Changed Coverage Δ
src/gate_applicators.jl 72.72% <72.72%> (-0.25%) ⬇️
PyBraket/src/pygates.jl 80.48% <80.48%> (-16.58%) ⬇️
src/gates.jl 92.30% <88.37%> (-1.03%) ⬇️
PyBraket/src/PyBraket.jl 87.17% <100.00%> (+0.33%) ⬆️
src/circuit.jl 99.34% <100.00%> (ø)
src/schemas.jl 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kshyatt-aws kshyatt-aws force-pushed the ksh/parametrizedgates branch from 3e5b4de to 93ecdb4 Compare July 29, 2023 15:22
@kshyatt-aws kshyatt-aws merged commit 01a7290 into main Jul 31, 2023
@kshyatt-aws kshyatt-aws deleted the ksh/parametrizedgates branch July 31, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants