-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change: get dimensions for aq.ArrayVar automatically #22
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 43 -1
Lines 1936 1903 -33
Branches 319 320 +1
=========================================
- Hits 1936 1903 -33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good - thank you for taking this on! Just a few small comments and suggestions.
d273c6f
to
1c42c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good! Couple of minor suggestions but after that I think this will be ready to go.
* change: get dimensions for aq.ArrayVar automatically reformat * change: add init_expression to ArrayVar explicitly * Add test for multidimensional array support remove print * Add type hint for init_expression * Add type hint test for init_expression
Issue #13:
Description of changes:
ArrayVar
intypes.py
, thedimensions
keyword argument is no longer required but inferred from the initial expression. The initial expression, however, becomes a necessary argument following the comments made on the issue.args[0]
is used because_ClassicalVar
inoqpy
'sArrayVar
suggestsinit_expression
is the first argument.Testing done: Yes.
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
args
andkwargs
, which remain unchanged?Tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.