Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove StackName from CW event rule target id #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove StackName from CW event rule target id #14

wants to merge 1 commit into from

Conversation

eliran89c
Copy link

remove AWS::StackName pseudo parameter from "sfRealTimeQueueMetricsCron.targets.1"

Description of changes:
when deploying this package as a nested stack it failed due to 64 characters limit

1 validation error detected: Value 'XXX-TTYSRYK8OZ3T-sfRealTimeQueue' at 'targets.1.member.id' failed to satisfy constraint: Member must have length less than or equal to 64 

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

remove StackName from "sfRealTimeQueueMetricsCron.target"
seiyako
seiyako previously approved these changes Oct 27, 2022
@srivanc srivanc dismissed stale reviews from seiyako and martin-greenberg November 22, 2022 19:17

We can't merge this as customers could have multiple SF lambdas in their account so they need this disambiguator

@rafalwrzeszcz
Copy link

@srivanc This is absolutely not true, ID is only identifying target within same rule and this each alarm has separate targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants