Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad performance due to zeroing large buffers #292

Closed
m6w6 opened this issue Apr 5, 2022 · 1 comment
Closed

bad performance due to zeroing large buffers #292

m6w6 opened this issue Apr 5, 2022 · 1 comment

Comments

@m6w6
Copy link
Contributor

m6w6 commented Apr 5, 2022

I just stumbled over a memset in ion_allocation.c:172, which seems to cause a quite big performance hit.

Consider the following two callgraphs of the same code, just once with that memset commented out:

With memset:

binary-w_memset

Without memset:

binary-wo_memset
@m6w6
Copy link
Contributor Author

m6w6 commented Apr 5, 2022

Unfortunately, there ARE crashes in tests/, which I'll look into.

m6w6 added a commit to m6w6/ion-c that referenced this issue Apr 5, 2022
@m6w6
fix amazon-ion#292: bad alloc performance due to excessive memset
ab2aba0
@m6w6 m6w6 mentioned this issue Apr 5, 2022
Merged
@tgregg tgregg closed this as completed in 70cb075 Apr 6, 2022
m6w6 added a commit to awesomized/ext-ion that referenced this issue Apr 26, 2022
@m6w6
reference fix for amazon-ion/ion-c#292
e621fd2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m6w6