adds changes for correctly setting stream position when error occurs while reading binary int64 #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…while reading binary int64
almann
requested changes
May 24, 2021
almann
approved these changes
May 24, 2021
test/test_ion_binary.cpp
Outdated
Comment on lines
436
to
438
| TEST(IonBinaryReader, ReaderNegativeThresholdForInt64) { | ||
| test_ion_binary_reader_threshold_for_int64((BYTE *)"\xE0\x01\x00\xEA\x38\xFF\xFF\xFF\xFF\xFF\xFF\xFF\xFF", 13, "-18446744073709551615"); | ||
| } |
There was a problem hiding this comment.
Very minor, but I think variants of the test with 2 ** 63 is interesting '\x80\x00\x00\x00\x00\x00\x00\x00' should fail for positive int, but not negative int (since -2 ** 63 fits as two's complement representation 0x8000000000000000).
almann
previously approved these changes
May 24, 2021
desaikd
added a commit
to amazon-ion/ion-rust
that referenced
this pull request
May 27, 2021
See amazon-ion/ion-c#244 for the fix around setting the binary reader's stream position back to the start of value when an error occurs in reading int64 value. Fixes #218
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR works on setting stream position correctly when error occurs in reading binary int64 value.
Changes:
Test:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.