Fixes an issue where offset capture of a multi-field struct was incor… #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly returning field name positions instead of value positions
…ead field names when moving to a position within a struct
tgregg
reviewed
Jun 16, 2021
test/test_ion_reader_seek.cpp
Outdated
Comment on lines
756
to
758
| // Easy assertions: there's only one value, "value," and we should have read it both times | ||
| assertStringsEqual((char *)value.value, cread_val1, strlen(cread_val1)); | ||
| assertStringsEqual((char *)value.value, cread_val2, strlen(cread_val2)); |
There was a problem hiding this comment.
This is probably good enough, but I would feel better about it if the values weren't the same. That way we know this won't happen to pass if the second seek somehow leaves the reader positioned at the first value.
tgregg
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where offset capture of a multi-field struct was incorrectly returning field name positions instead of value positions
Description of changes:
This adds a condition to the resetting of the
value_startposition during the_nextoperation to bring the behavior of the text reader in line with the binary reader when doing offset capture.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.