Fixes a memory leak issue in reader API. #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change it back to draft mode as it fails GH Actions. |
tgregg
reviewed
Dec 1, 2021
ionc/ion_reader.c
Outdated
| @@ -1917,7 +1917,12 @@ iERR _ion_reader_process_possible_symbol_table(ION_READER *preader, BOOL *is_sym | |||
| preader->_local_symtab_pool = owner; | |||
| preader->_current_symtab = local; | |||
| } | |||
| iRETURN; | |||
| SUCCEED(); | |||
There was a problem hiding this comment.
This is how SUCCEED is defined:
#define SUCCEED() { err = IERR_OK; goto fail; }
So this line will jump to the fail label on the next line and free the owner, if any. It looks like that's not actually what we want; in the successful case we don't want to free the owner. This line should be replaced by return IERR_OK;
I think this is why the tests are failing.
There was a problem hiding this comment.
Got it thanks. Change it to return IERR_OK works.
tgregg
approved these changes
Dec 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was mentioned in amazon-ion/ion-python#172 (comment)
Owner should be released when the method fails.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.