ion_catalog_find_symbol_table doesn't find anything #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m6w6
force-pushed
the
ion_catalog_find_symbol_table
branch
2 times, most recently
from
1cb8b02
to
b0bcc6f
Compare
m6w6
added a commit
to awesomized/ext-ion
that referenced
this pull request
Dec 21, 2021
|
Sorry, the first patch was broken, too, though accidentally working for me in a quick test at first. Looks better now. |
m6w6
force-pushed
the
ion_catalog_find_symbol_table
branch
from
b0bcc6f
to
60fa439
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
ion_catalog_find_symbol_table() doesn't find anything because of not using pointers correctly with the ION_COLLECTION API.
Just compare the code of
_ion_catalog_find_symbol_table_helper()with_ion_catalog_find_best_match_helper().By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.