Fix support for ion-c used with add_subdirectory in parent project #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
This PR fixes some variables used in the version header generation, that resulted in a cmake project not being able to include ion-c via
add_subdirectory.The variables originally used were build-wide binary and source directories. The fix changes them to more localized directories where the ion-c specific files would be located. In addition to writing the header to the wrong location, the git command used to generate the version would also run in the wrong directory gathering the wrong version, or no version at all. This was also fixed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.