Fix amazonlinux 1 & 2 builds #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…irement of node20
|
Added an issue (#346) to give some TLC to Amazon Linux versions in our workflows. |
linlin-s
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: n/a
Description of changes:
GitHub has changed the default nodejs used for actions to node20, which requires a more recent glibc than amazonlinux 1 & 2 have. This PR uses GH provided env variables to force the runner to use node16 which will work with amazonlinux 1 & 2.
Amazon Linux 2 was supposed to be EOL'd a year ago, but support was extended until June of 2025.
Amazon Linux 1 has been EOL'd since Jan 1st 2024, after also being extended.
Node16 will probably be removed from the GHA runner before Amazon Linux 2 is EOL'd, so we'll have to determine if we can work around it, or if we should just move everything over to Amazon Linux 2023.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.