Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for struct with both type and fields constraint #116

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

desaikd
Copy link
Contributor

@desaikd desaikd commented Jun 5, 2024

Issue #, if available:

Description of changes:

This PR works on adding support for struct with both type and fields constraint.

List of changes:

  • Modified map_constraint_to_abstract_data_type to add support for type: struct.
  • Currently implementation returns an error if only type: struct was used without fields constraints.
  • Generated code remains same as per fields constraint.

Tests:

Modified current tests and add an invalid test case for only type:struct constraint inside a type def.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@desaikd desaikd requested a review from popematt June 5, 2024 22:27
@desaikd desaikd merged commit 7e5577a into amazon-ion:master Jun 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants