Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top-level containers are no longer followed by a comma #31

Merged
merged 2 commits into from
Aug 11, 2022

Conversation

zslayton
Copy link
Contributor

This PR depends on #30. Once 30 has been merged, this one will be rebased against master.


PR #28 attempted to fix #17, but overcorrected.

Previously, nested containers would not be followed by a delimiting ,:

[
  {}
  {}
  {}
]

Following #28, this was fixed:

[
  {},
  {},
  {},
]

but it also added commas after top-level containers:

$ion_symbol_table::{
  // ....
},
{
  foo: true
},
{
  bar: 5
},

which is incorrect.

This PR fixes that behavior.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Base automatically changed from readme-examples to master August 11, 2022 01:28
@zslayton zslayton merged commit 20ce94a into master Aug 11, 2022
@zslayton zslayton deleted the nested-container-comma-fix branch August 11, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inspect doesn't write delimiting commas after nested containers
3 participants