-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds bugfixes for generated code #90
Conversation
260b0fe
to
76368b4
Compare
76368b4
to
4e6b375
Compare
As per an offline discussion, there is a possible solution for generated code testing without the need to create |
code-gen-core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to make the generated types implement WriteAsIon
? I think that will make it easier overall, especially since there's already things like impl <T> WriteAsIon for Vec<T> where T: WriteAsIon
.
a91dae2
to
8986134
Compare
Issue #88:
Description of changes:
This PR includes the first prerequisites of #88. This PR adds some bug fixes for the generated code.
List of changes:
code-gen-core
.is_root_type
inCodeGenerator
, this will be used for stepping in for root and type for consecutive calls just callingnext
. (Note: This will be removed once we have Lazy Reader APIs)AbstractDataType::Struct
that will be used by template to check if the generated struct is closed or can contain open content. (Note: This just sets up the parameter to the enum but is not yet being used by template, those changes will arrive in later PRs.)Field
entry that is used by template now stores the ISL type name as that will be used to determine calling read/write_sym/string, blob/clob etc.Tests:
Still uses the older tests in
ion-cli
but will be refactored in following PRs to use new roundtrip tests.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.