Fix certain symbols being incorrectly identified as incomplete boolean values #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popematt
commented
Jul 11, 2024
Comment on lines
-1065
to
+1068
| alt((value(true, tag("true")), value(false, tag("false")))), | ||
| alt(( | ||
| value(true, complete_tag("true")), | ||
| value(false, complete_tag("false")), | ||
| )), |
There was a problem hiding this comment.
🗺️ This is the logic change. The rest of the changes in this file are (a) separating out mismatch and incomplete in the tests cases, and (b) introducing a macro to eliminate most of the nested functions, boilerplate code, and repeated code in the test cases.
zslayton
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
None
Description of changes:
Fixes a small bug in
match_boolthat was incorrectly reporting things like "fal" as incomplete booleans rather than as non-matches.Also adds test cases, and updates existing test cases with a more concise macro and the ability to specify whether a value is a mismatch vs an incomplete match.
You may want to view this PR in the "split" diff view.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.